COMMUNITY FORUM

After updating to version 2.9 "tag rating" doesnt display the log

Franz Heine
Topic Author
Offline
Premium Member

6 years 2 months ago #169257 by Franz Heine

After updating to version 2.9 "tag rating" doesnt display the log was created by Franz Heine

Hi,

ive updated from 2.8 to 2.9

Ive "extended" my tag.php with the rating like this:

<?php if($item->params->get('catItemRating')): ?>
	<!-- Item Rating -->
	<div class="catItemRatingBlock">
		<div class="itemRatingForm">
			<ul class="itemRatingList">
				<li class="itemCurrentRating" id="itemCurrentRating<?php echo $item->id; ?>" style="width:<?php echo $item->votingPercentage; ?>%;"></li>
				<li><a href="#" data-id="<?php echo $item->id; ?>" title="<?php echo JText::_('K2_1_STAR_OUT_OF_5'); ?>" class="one-star">1</a></li>
				<li><a href="#" data-id="<?php echo $item->id; ?>" title="<?php echo JText::_('K2_2_STARS_OUT_OF_5'); ?>" class="two-stars">2</a></li>
				<li><a href="#" data-id="<?php echo $item->id; ?>" title="<?php echo JText::_('K2_3_STARS_OUT_OF_5'); ?>" class="three-stars">3</a></li>
				<li><a href="#" data-id="<?php echo $item->id; ?>" title="<?php echo JText::_('K2_4_STARS_OUT_OF_5'); ?>" class="four-stars">4</a></li>
				<li><a href="#" data-id="<?php echo $item->id; ?>" title="<?php echo JText::_('K2_5_STARS_OUT_OF_5'); ?>" class="five-stars">5</a></li>
			</ul>
			<div id="itemRatingLog<?php echo $item->id; ?>" class="itemRatingLog"><?php echo $item->numOfvotes; ?></div>
			<div class="clr"></div>
		</div>
		<div class="clr"></div>
	</div>
	<?php endif; ?>

in version 2.8. it works. Do ive to change the code?

Thx

Please Log in or Create an account to join the conversation.

JoomlaWorks
Offline
Admin

6 years 2 months ago #169271 by JoomlaWorks

Replied by JoomlaWorks on topic After updating to version 2.9 "tag rating" doesnt display the log

If this is in an override (inside your template), you should be fine.

Fotis / JoomlaWorks Support Team
---
Please search the forum before posting a new topic :)

Please Log in or Create an account to join the conversation.

Franz Heine
Topic Author
Offline
Premium Member

6 years 2 months ago #169279 by Franz Heine

Replied by Franz Heine on topic After updating to version 2.9 "tag rating" doesnt display the log

Hi Fotis,

it is is the template overrides. The rating works, but if i refresh the site, i cannot see immediately the "votingpercentage" and the "numofvotes".

Just after a current rating, ill see these informations. Seems to be a script problem

you can check it here:

lastschrift-bezahlen.de/alle-shops/sale.html

Please Log in or Create an account to join the conversation.

JoomlaWorks
Offline
Admin

6 years 2 months ago #169295 by JoomlaWorks

Replied by JoomlaWorks on topic After updating to version 2.9 "tag rating" doesnt display the log

I think the issue is related to your lazy load plugin.

Fotis / JoomlaWorks Support Team
---
Please search the forum before posting a new topic :)

Please Log in or Create an account to join the conversation.

Franz Heine
Topic Author
Offline
Premium Member

6 years 2 months ago #169325 by Franz Heine

Replied by Franz Heine on topic After updating to version 2.9 "tag rating" doesnt display the log

it must be the version. I had another project. 2.8 works fine, 2.9 same result. Ive deactivated the "lazy load plugin". Nothing changed.

Could it be a javascript error?

Please Log in or Create an account to join the conversation.

JoomlaWorks
Offline
Admin

6 years 2 months ago #169339 by JoomlaWorks

Replied by JoomlaWorks on topic After updating to version 2.9 "tag rating" doesnt display the log

Disable JCH Optimize and test again (make sure you clear your J cache after that). If that's the issue, either add k2.css as an exception or skip CSS compression overall. There are no JS issues on your site.

Fotis / JoomlaWorks Support Team
---
Please search the forum before posting a new topic :)

Please Log in or Create an account to join the conversation.

Franz Heine
Topic Author
Offline
Premium Member

6 years 2 months ago #169354 by Franz Heine

Replied by Franz Heine on topic After updating to version 2.9 "tag rating" doesnt display the log

Hi Fotis,

thank you first of all for your effort.

JCH wasnt the problem, even without the active plugin (empty cache) ive this issue. In the category and item view everything is fine, just the tag view causes this issue.

Please Log in or Create an account to join the conversation.

JoomlaWorks
Offline
Admin

6 years 1 month ago #169369 by JoomlaWorks

Replied by JoomlaWorks on topic After updating to version 2.9 "tag rating" doesnt display the log

Disable JCH and let me know so I can have a look and verify it's not to blame here. It would also help with the debugging process. FYI if you use HTTP/2 on your server (or via CloudFlare) you don't really need CSS/JS compression anymore.

Fotis / JoomlaWorks Support Team
---
Please search the forum before posting a new topic :)

Please Log in or Create an account to join the conversation.

Franz Heine
Topic Author
Offline
Premium Member

6 years 1 month ago - 6 years 1 month ago #169382 by Franz Heine

Replied by Franz Heine on topic After updating to version 2.9 "tag rating" doesnt display the log

@JCH: is off.
@Site:
lastschrift-bezahlen.de/alle-shops/computer-pc/ipad.html
@http/2: server provides it. On tools like gtmetrix.com i get better results for css/js compression (less requests, less page size etc.) Would you still "deactivate" tools like JCH?

Thx!

Last edit: 6 years 1 month ago by Franz Heine.

Please Log in or Create an account to join the conversation.

JoomlaWorks
Offline
Admin

6 years 1 month ago #169394 by JoomlaWorks

Replied by JoomlaWorks on topic After updating to version 2.9 "tag rating" doesnt display the log

GTmetrix simply scans the HTML it reads. It does not act as a real browser. So it should be taken with a grain of salt.

Something is removing the width value from the rating. It could also be an override with missing PHP variables. But since we haven't changed anything in relation to that since 2.8.0, my guess is JCH or another performance plugin is stripping that out (perhaps becuase it "sees" this as inline CSS). When you hit a star to rate, K2's JS kicks in and re-writes the width value, that's why you only see the rating after you add yours.

Fotis / JoomlaWorks Support Team
---
Please search the forum before posting a new topic :)

Please Log in or Create an account to join the conversation.