- Posts: 24
COMMUNITY FORUM
- Forum
- Commercial Joomla Extensions & Templates
- Frontpage Slideshow
- Linking some slides but not all of them .. bug fix
Please note that official support for commercial extensions & templates is provided in the Subscriber Help Desk.
Support requests should ONLY be directed there and require an active subscription plan.
This forum board is to be used for archive purposes and knowledge exchange ONLY.
Support requests should ONLY be directed there and require an active subscription plan.
This forum board is to be used for archive purposes and knowledge exchange ONLY.
Linking some slides but not all of them .. bug fix
- cvoogt
- Topic Author
- Offline
- Junior Member
Less
More
13 years 2 months ago #42766
by cvoogt
Linking some slides but not all of them .. bug fix was created by cvoogt
When it comes to linking slides, it seems you can choose to display links for all slides, or not.
But what if you want links on some slides but not others? In such a case, if the user did not supply a URL, the link will say "www.yoursite.com/URL". You could enter "#" or "javascript:;" as the URL, but one cannot expect non web developers to remember to do this. The user should not be required to take additional action just to NOT link a slide.
We wrote a quick fix for this. Open up the default.php template file for the FPSS layout you're using. We used JJ-Oobs so we opened up /modules/mod_fpss/tmpl/JJ-Obs/default.php. Right after "foreach($slides as $slide):" insert the following:
We used a "javascript:;" URL rather than "#" because this way if you slideshow is far down the page, clicking it will not take you back to the top of the page ... using "#" can conflict with named anchors but "javascript:;" does not.
We put this modification in this file rather than in /templates/yourtemplate/html/mod_fpss/JJ-Obs/default.php because when we tried putting it in there the layout got messed up and the slides actually animated diagonally when we just had wanted them fading in and out .. normally we would want to use an MVC override in the template folder but in this case that seemed buggy too.
But what if you want links on some slides but not others? In such a case, if the user did not supply a URL, the link will say "www.yoursite.com/URL". You could enter "#" or "javascript:;" as the URL, but one cannot expect non web developers to remember to do this. The user should not be required to take additional action just to NOT link a slide.
We wrote a quick fix for this. Open up the default.php template file for the FPSS layout you're using. We used JJ-Oobs so we opened up /modules/mod_fpss/tmpl/JJ-Obs/default.php. Right after "foreach($slides as $slide):" insert the following:
if($slide->link == 'URL'){
$slide->link = 'javascript:;';
}
We used a "javascript:;" URL rather than "#" because this way if you slideshow is far down the page, clicking it will not take you back to the top of the page ... using "#" can conflict with named anchors but "javascript:;" does not.
We put this modification in this file rather than in /templates/yourtemplate/html/mod_fpss/JJ-Obs/default.php because when we tried putting it in there the layout got messed up and the slides actually animated diagonally when we just had wanted them fading in and out .. normally we would want to use an MVC override in the template folder but in this case that seemed buggy too.
Please Log in or Create an account to join the conversation.
- Lefteris
- Offline
- Moderator
Less
More
- Posts: 8743
13 years 2 months ago #42767
by Lefteris
JoomlaWorks Support Team
---
Please search the forum before posting a new topic :)
Replied by Lefteris on topic Re: Linking some slides but not all of them .. bug fix
Hi. This is a matter of logic. We will take a look at the issue. Thanks for your recommendations.
JoomlaWorks Support Team
---
Please search the forum before posting a new topic :)
Please Log in or Create an account to join the conversation.
- cvoogt
- Topic Author
- Offline
- Junior Member
Less
More
- Posts: 24
13 years 2 months ago #42768
by cvoogt
Replied by cvoogt on topic Re: Linking some slides but not all of them .. bug fix
Well, I have also noticed that I cannot seem to link a menu item.
I can only get it working using a normal URL, and instead of my JavaScript hack I am now just linking to # if I don't want the slide linking anywhere.
I have also noticed the slide title gets cleared on me when I select Menu as my link option .. so that I have to re-type the slide title. This was in Chrome; have not tested other browsers.
I can only get it working using a normal URL, and instead of my JavaScript hack I am now just linking to # if I don't want the slide linking anywhere.
I have also noticed the slide title gets cleared on me when I select Menu as my link option .. so that I have to re-type the slide title. This was in Chrome; have not tested other browsers.
Please Log in or Create an account to join the conversation.
- Martin Montgomery
- Offline
- New Member
Less
More
- Posts: 2
13 years 1 month ago #42769
by Martin Montgomery
Replied by Martin Montgomery on topic Re: Linking some slides but not all of them .. bug fix
Hi,
I have tried this, but seem to be having problems implementing it - however I wish to ask is there any way you can link the read more and title in the text, but NOT the images? Is there someone who could send me a bit of code to get this to work?
My reasons are because I want to use the image as a large background which scrolls behind the container html with the intro text floated at the top, but with the image being so large, visitors will click the image by accident - so I want to remove the links.
Any help is gratefully received!
Martin
I have tried this, but seem to be having problems implementing it - however I wish to ask is there any way you can link the read more and title in the text, but NOT the images? Is there someone who could send me a bit of code to get this to work?
My reasons are because I want to use the image as a large background which scrolls behind the container html with the intro text floated at the top, but with the image being so large, visitors will click the image by accident - so I want to remove the links.
Any help is gratefully received!
Martin
Please Log in or Create an account to join the conversation.
- Martin Montgomery
- Offline
- New Member
Less
More
- Posts: 2
13 years 1 month ago #42770
by Martin Montgomery
Replied by Martin Montgomery on topic Re: Linking some slides but not all of them .. bug fix
Double post I know, but to help with others who may have downloaded the newer version and cant get the bug fix to work, you have to disable the stats option in the config menu of fpss.
Took me a while to figure that out.
But I would still like the option to link using text and not the images if at all possible...
Thanks
Took me a while to figure that out.
But I would still like the option to link using text and not the images if at all possible...
Thanks
Please Log in or Create an account to join the conversation.
- AverageJoe
- Offline
- New Member
Less
More
- Posts: 10
12 years 8 months ago #42771
by AverageJoe
Replied by AverageJoe on topic Re: Linking some slides but not all of them .. bug fix
Hello, I know this is an old topic, but apparently it is still relevant as the latest FPSS still does not correct this issue. Will FPSS 3.x ever allow us to link certain slides and not others without needing to incorporate this bug fix? Seeing as it apparently cannot be fixed from the template HTML folder without issues, this is a very annoying. You guys do a great job with this extension! I just wish this feature carried over from the 2.x series. Any update info would be welcomed! Thanks!
Please Log in or Create an account to join the conversation.
- Katia
- Offline
- Platinum Member
Less
More
- Posts: 4696
12 years 8 months ago #42772
by Katia
JoomlaWorks Support Team
---
Please search the forum before posting a new topic :)
Replied by Katia on topic Re: Linking some slides but not all of them .. bug fix
Which FPSS version do you use?
JoomlaWorks Support Team
---
Please search the forum before posting a new topic :)
Please Log in or Create an account to join the conversation.
- vpayne
- Offline
- New Member
Less
More
- Posts: 12
12 years 8 months ago #42773
by vpayne
Replied by vpayne on topic Re: Linking some slides but not all of them .. bug fix
Thanks for this bug-fix, cvoogt - and for acknowledging it, Lefteris.
It is the same bug described in forum.joomlaworks.net/frontpage-slideshow-%28for-joomla!%29/fpss-3-2-0-slide-with-no-link-goes-to-page-not-found/ .
It would be very nice to see this (or a similar fix) implemented in the next FPSS version. Any idea when the next version will be released?
Katia, incidentally, this bug exists in all versions of FPSS 3.*
It is the same bug described in forum.joomlaworks.net/frontpage-slideshow-%28for-joomla!%29/fpss-3-2-0-slide-with-no-link-goes-to-page-not-found/ .
It would be very nice to see this (or a similar fix) implemented in the next FPSS version. Any idea when the next version will be released?
Katia, incidentally, this bug exists in all versions of FPSS 3.*
Please Log in or Create an account to join the conversation.
- AverageJoe
- Offline
- New Member
Less
More
- Posts: 10
12 years 8 months ago #42774
by AverageJoe
Replied by AverageJoe on topic Re: Linking some slides but not all of them .. bug fix
Hi Katia, I'm using 3.2.0 on J!2.5
Please Log in or Create an account to join the conversation.
- Forum
- Commercial Joomla Extensions & Templates
- Frontpage Slideshow
- Linking some slides but not all of them .. bug fix