- Posts: 11
COMMUNITY FORUM
recaptcha boken in svn revision 391
- lynton
- Topic Author
- Offline
- New Member
Less
More
14 years 8 months ago #80175
by lynton
recaptcha boken in svn revision 391 was created by lynton
Hi, I recently downloaded the svn revision 391 to solve another issue I had.
After doing so I found that recaptcha on the comments form on my site no longer worked.
It had been working previously with the 2.2 release.
I don't know if I should be posing bugs about unreleased code but thought I should let you know about it.
The recapture_ajax.js is not being loaded and after debugging I found the culprits lines of code
at line 101 of views/item/tmpl/view.html.php
and line 105 of views/item/tmpl/view.raw.php
this same line uses the wrong variable to determine the user status in each of these files.
if ($item->params->get('recaptcha') && $this->user->guest) {
it should be
if ($item->params->get('recaptcha') && $user->guest) {
there may be other places as well but changing these two lines fixed it for me.
forgive me if this is not the way to get this fixed, I'm fairly new here.
regards
lynton
After doing so I found that recaptcha on the comments form on my site no longer worked.
It had been working previously with the 2.2 release.
I don't know if I should be posing bugs about unreleased code but thought I should let you know about it.
The recapture_ajax.js is not being loaded and after debugging I found the culprits lines of code
at line 101 of views/item/tmpl/view.html.php
and line 105 of views/item/tmpl/view.raw.php
this same line uses the wrong variable to determine the user status in each of these files.
if ($item->params->get('recaptcha') && $this->user->guest) {
it should be
if ($item->params->get('recaptcha') && $user->guest) {
there may be other places as well but changing these two lines fixed it for me.
forgive me if this is not the way to get this fixed, I'm fairly new here.
regards
lynton
Please Log in or Create an account to join the conversation.
- Lefteris
- Offline
- Moderator
Less
More
- Posts: 8743
14 years 8 months ago #80176
by Lefteris
JoomlaWorks Support Team
---
Please search the forum before posting a new topic :)
Replied by Lefteris on topic recaptcha boken in svn revision 391
Hi. You are right. Just fixed it. Note that using SVN version may lead you to similar bugs. If you find any please post it here. Thanks for reporting this issue to us.
JoomlaWorks Support Team
---
Please search the forum before posting a new topic :)
Please Log in or Create an account to join the conversation.
- lynton
- Topic Author
- Offline
- New Member
Less
More
- Posts: 11
14 years 8 months ago #80177
by lynton
Replied by lynton on topic recaptcha boken in svn revision 391
Was this the correct fix ?
I am not all that familiar with the code but it looked right to me.
Yes I understand that this is the development tree, that's why I was unsure whether posting bugs was the "right" thing to do. I'm actually a software developer myself and well acquainted with svn repositories.
b.t.w the problem with the single category latest items is also now fixed thanks for that.
Lefteris Kavadas said:Hi. You are right. Just fixed it. Note that using SVN version may lead you to similar bugs. If you find any please post it here. Thanks for reporting this issue to us.
I am not all that familiar with the code but it looked right to me.
Yes I understand that this is the development tree, that's why I was unsure whether posting bugs was the "right" thing to do. I'm actually a software developer myself and well acquainted with svn repositories.
b.t.w the problem with the single category latest items is also now fixed thanks for that.
Lefteris Kavadas said:Hi. You are right. Just fixed it. Note that using SVN version may lead you to similar bugs. If you find any please post it here. Thanks for reporting this issue to us.
Please Log in or Create an account to join the conversation.
- Lefteris
- Offline
- Moderator
Less
More
- Posts: 8743
14 years 8 months ago #80178
by Lefteris
JoomlaWorks Support Team
---
Please search the forum before posting a new topic :)
Replied by Lefteris on topic recaptcha boken in svn revision 391
Hi. Yes the fix was correct. Thanks again.
Lynton Reed said:Was this the correct fix ? I am not all that familiar with the code but it looked right to me.
Yes I understand that this is the development tree, that's why I was unsure whether posting bugs was the "right" thing to do. I'm actually a software developer myself and well acquainted with svn repositories.
b.t.w the problem with the single category latest items is also now fixed thanks for that.
Lefteris Kavadas said:Hi. You are right. Just fixed it. Note that using SVN version may lead you to similar bugs. If you find any please post it here. Thanks for reporting this issue to us.
Lynton Reed said:Was this the correct fix ? I am not all that familiar with the code but it looked right to me.
Yes I understand that this is the development tree, that's why I was unsure whether posting bugs was the "right" thing to do. I'm actually a software developer myself and well acquainted with svn repositories.
b.t.w the problem with the single category latest items is also now fixed thanks for that.
Lefteris Kavadas said:Hi. You are right. Just fixed it. Note that using SVN version may lead you to similar bugs. If you find any please post it here. Thanks for reporting this issue to us.
JoomlaWorks Support Team
---
Please search the forum before posting a new topic :)
Please Log in or Create an account to join the conversation.
- lynton
- Topic Author
- Offline
- New Member
Less
More
- Posts: 11
14 years 8 months ago #80179
by lynton
Replied by lynton on topic recaptcha boken in svn revision 391
no worries, great to be able to help out even if only in a small way.
Please Log in or Create an account to join the conversation.