COMMUNITY FORUM

Please note that official support for commercial extensions & templates is provided in the Subscriber Help Desk.
Support requests should ONLY be directed there and require an active subscription plan.
This forum board is to be used for archive purposes and knowledge exchange ONLY.

Can't get SIG working on IE

Start
Prev
1
Next
End

FidoBoy
Topic Author
Offline
New Member

15 years 4 months ago #26065 by FidoBoy

Can't get SIG working on IE was created by FidoBoy

I can't get this plugin to work on IE browsers. It works fine on FireFox, Chrome and Safari. I'm using the Highslide engine and the problem seems to be in the file popup.php in this function:

// Load HighSlide
	function loadHighSlide() {
		if(!document.getElementsByTagName) return false;
		if(!document.getElementById) return false;
		var a = document.getElementsByTagName("a");
		for(var i=0; i<a.length; i++){
			if(/highslide/.test(a[i].getAttribute("class"))){
				alert("working");
				a[i].onclick = function(){
					return hs.expand(this);
					return false;
				}
			}
		}
	}

I've added an alert to verify if the function is working fine. The alert is being shown on FF and other browsers but not on IE. There is not javascript errors in the page.

regards,

Please Log in or Create an account to join the conversation.

FidoBoy
Topic Author
Offline
New Member

15 years 4 months ago - 15 years 4 months ago #26066 by FidoBoy

Replied by FidoBoy on topic Re: Can't get SIG working on IE

Well, after a deeper investigation i've solved this problem on my own. I'll post here my modifications, because may be that it helps to other users and may be that it can be added in new version of SIG.

function loadHighSlide() {
		if(!document.getElementsByTagName) return false;
		if(!document.getElementById) return false;
		var a = document.getElementsByTagName("a");
		for(var i=0; i<a.length; i++){
			if(/highslide/.test(a[i].getAttribute("className")) || /highslide/.test(a[i].getAttribute("class"))){
				a[i].onclick = function(){
					return hs.expand(this);
					return false;
				}
			}
		}
	}

This is the modified function and, as you can see, i've checked both 'class' and 'className' attributes because the 'class' attribute is not working in IE. This way it always find the right tags.

I hope that you can find it useful. Kind regards!

Please Log in or Create an account to join the conversation.

JoomlaWorks
Offline
Admin

15 years 4 months ago #26067 by JoomlaWorks

Replied by JoomlaWorks on topic Re: Can't get SIG working on IE

Thanks for noting that. I'll make sure to update our code in v2.0.5 coming soon.

Fotis / JoomlaWorks Support Team
---
Please search the forum before posting a new topic :)

Please Log in or Create an account to join the conversation.

JoomlaWorks
Offline
Admin

13 years 6 months ago #26068 by JoomlaWorks

Replied by JoomlaWorks on topic Re: Can't get SIG working on IE

Fixed in the upcoming 2.5 release.

Fotis / JoomlaWorks Support Team
---
Please search the forum before posting a new topic :)

Please Log in or Create an account to join the conversation.

Start
Prev
1
Next
End